-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(@angular/cli): increase keepAliveTimeout for all Node 8 versions #7832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis is failing on the commit message, can you change it to fix(@angular/cli): increase keepAliveTimeout for all Node 8 versions
please?
Done. All checks have passed, no idea why travis failed before |
We have a check for the commit message which makes one of the jobs fail. Your new commit message solved that 👍 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #7197, in continuation to #7563
Thanks @mtraynham for the original fix.
This resolves an issue with browsers throwing net::ERR_CONTENT_LENGTH_MISMATCH for large files or slow connections, when using Webpack Dev Server. Large files, such as a vendor javascript bundle, are susceptible to this bug which is tracked all the way back to the NodeJS http module. A change in NodeJS 8.0 broke the keepAliveTimeout handling where active requests don't reset the timeout timer. This is a proposal fix in NodeJS 8.6, but that is what was last time as well.
The keepAliveTimeout defaults to 5 seconds, which may be too short. This change increases that keepAliveTimeout to 30 seconds, but only if the Node process has versions starting with 8