Skip to content

fix(@angular/cli): increase keepAliveTimeout for all Node 8 versions #7832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2017
Merged

Conversation

AmitMY
Copy link
Contributor

@AmitMY AmitMY commented Sep 26, 2017

Fixes #7197, in continuation to #7563

Thanks @mtraynham for the original fix.

This resolves an issue with browsers throwing net::ERR_CONTENT_LENGTH_MISMATCH for large files or slow connections, when using Webpack Dev Server. Large files, such as a vendor javascript bundle, are susceptible to this bug which is tracked all the way back to the NodeJS http module. A change in NodeJS 8.0 broke the keepAliveTimeout handling where active requests don't reset the timeout timer. This is a proposal fix in NodeJS 8.6, but that is what was last time as well.

The keepAliveTimeout defaults to 5 seconds, which may be too short. This change increases that keepAliveTimeout to 30 seconds, but only if the Node process has versions starting with 8

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@AmitMY
Copy link
Contributor Author

AmitMY commented Sep 26, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this 👍

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis is failing on the commit message, can you change it to fix(@angular/cli): increase keepAliveTimeout for all Node 8 versions please?

@AmitMY AmitMY changed the title fix(serve): increase keepAliveTimeout for all Node 8 versions fix(@angular/cli): increase keepAliveTimeout for all Node 8 versions Sep 26, 2017
@AmitMY
Copy link
Contributor Author

AmitMY commented Sep 26, 2017

Done. All checks have passed, no idea why travis failed before

@filipesilva
Copy link
Contributor

We have a check for the commit message which makes one of the jobs fail. Your new commit message solved that 👍

@filipesilva filipesilva merged commit a9f6702 into angular:master Sep 26, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Big bundle requests failing with net::ERR_CONTENT_LENGTH_MISMATCH
3 participants