Ref #7197 - Increase keepAliveTimeout for Webpack Dev Server

[mtraynham]

Fixes #7197

This resolves an issue with browsers throwing net::ERR_CONTENT_LENGTH_MISMATCH for large files or slow connections, when using Webpack Dev Server. Large files, such as a vendor javascript bundle, are susceptible to this bug which is tracked all the way back to the NodeJS http module. A change in NodeJS 8.0 broke the keepAliveTimeout handling where active requests don't reset the timeout timer. This is fixed in NodeJS 8.5.

The keepAliveTimeout defaults to 5 seconds, which may be too short. This change increases that keepAliveTimeout to 30 seconds, but only if the Node process has versions between 8.0 - 8.4.

I'd like to mention, I don't use Angular CLI and haven't tried this fix with Angular CLI specifically. I have however verified it works when using Webpack Dev Server standalone.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

[mtraynham]

I signed it!

[googlebot]

CLAs look good, thanks!

[filipesilva]

Thanks for implementing this fix 👍

The CI is failing only because of the commit name. Can you change it to fix(@angular/cli): Increase keepAliveTimeout for Webpack Dev Server please?

[mtraynham]

You're welcome. I've reworded the commit message to your suggestion. Let me know if there's anything else I can do.

[filipesilva]

I think that was the only thing missing. We can merge after CI is green.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}