chore(lint): lint ts as well as js #1823
Conversation
| "lint": "eslint ." | ||
| "lint-js": "eslint .", | ||
| "lint-ts": "tslint \"**/*.ts\" -c tslint.json -e \"**/__path__/*.ts\" -e \"node_modules/**\" -e \"tmp/**\"", | ||
| "lint": "npm-run-all -c lint-js lint-ts" |
There was a problem hiding this comment.
If you're running them sequentially, just do npm run foo bar and skip a dependency.
There was a problem hiding this comment.
Tried doing that, but it seems to just send the second one as an argument:
$ npm run lint-js lint-ts
> angular-cli@1.0.0-beta.11-webpack.2 lint-js D:\work\angular-cli
> eslint . "lint-ts"
|
2 nits. Also, travis fails the lint test. |
|
The lint errors I'll address tomorrow probably. There are a fair amount of them. |
filipesilva
force-pushed
the
lint-ts
branch
3 times, most recently
from
145d320 to
640a008
Compare
| @@ -49,7 +49,9 @@ | |||
| true, | |||
| "ban-keywords", | |||
| "check-format", | |||
| "allow-trailing-underscore" | |||
| "allow-leading-underscore", | |||
There was a problem hiding this comment.
We'll want to allow one or the other, not both, but I'm fine with it for now (I know it's a big one).
There was a problem hiding this comment.
Done, left allow-leading-underscore only.
There was a problem hiding this comment.
Perfect, that's what Angular uses.
|
LGTM. |
|
Please rebase and I'll merge when I can. |
|
Rebased and pushed. Have a quick review and check the linux CI before merging though, stuff might have been broken. |
|
Still LGTM. I'll merge. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
We weren't linting TS files as part of the CI, so a lot of linting errors were going unnoticed.