fix: tslint

[catull]

1. OS
   OS X 10.11.6 (El Capitan), but it is platform-independent
2. Versions.
   From master after issue chore(lint): lint ts as well as js #1823 was committed
3. Repro steps.
   If "no-shadowed-variable": true is added to tsconfig.json's rules.
   Run npm run tslint
4. The log given by the failure.

addon/ng2/utilities/get-dependent-files.ts[50, 13]: Shadowed variable: 'node'
addon/ng2/utilities/get-dependent-files.ts[51, 11]: Shadowed variable: 'node'
packages/ast-tools/src/node.ts[24, 43]: Shadowed variable: 'node'
packages/ast-tools/src/route-utils.spec.ts[465, 13]: Shadowed variable: 'editedFile'
packages/ast-tools/src/route-utils.spec.ts[497, 13]: Shadowed variable: 'editedFile'

1. Mention any other details that might be useful.
   IMHO, shadowed variables are an invitation for subtle bugs to come see us and remain invisible.

I vote for non-shadowed variable to be true rather than false.

[catull]

This can be fixed by either disabling tslint, or by renaming
node -> aNode
editedFile -> editedFile2 (occurence in line 465)
editedFile -> editedFile3 (occurence in line 497)

[filipesilva]

We talked about this internally when adding TS linting, and at the time decided that adding that rule wasn't really worth making the code less readable since we overall use a lot of function shorthand.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}