Skip to content

[LTS] fix(@angular-devkit/build-angular): add sourceMappingURL comment for … #16525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2020
Merged

[LTS] fix(@angular-devkit/build-angular): add sourceMappingURL comment for … #16525

merged 2 commits into from
Jan 2, 2020

Conversation

alan-agius4
Copy link
Collaborator

Cherry-pick of #16524 for LTS

@alan-agius4
Copy link
Collaborator Author

Seems like there is a missing comment or something which is still causing patch to fail the tests.

Will investigate.

…ES2015 during differential loading

When having differential loading enabled we only add the `sourceMappingURL` comment when optimization is enabled, because we only process these bundles when we enabling optimization.

With this change we now process such bundles even when optimization is disabled and add `sourceMappingURL` when source maps are enabled and not hidden.

Closes #16522
@vikerman vikerman merged commit 39aa627 into angular:8.3.x Jan 2, 2020
@alan-agius4 alan-agius4 deleted the sourcemaps-dl-lts branch January 2, 2020 23:27
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants