fix(@angular-devkit/build-angular): add sourceMappingURL comment for …#16524
fix(@angular-devkit/build-angular): add sourceMappingURL comment for …#16524vikerman merged 1 commit intoangular:masterfrom alan-agius4:sourcemaps-dl
Conversation
alan-agius4
added
PR target: LTS-only
target: patch
clydin
left a comment
clydin
left a comment
There was a problem hiding this comment.
One change request otherwise looks good.
| result.downlevel = await processBundle({ | ||
| ...options, | ||
| code: downlevelCode, | ||
| map: downlevelMap && JSON.stringify(downlevelMap), |
There was a problem hiding this comment.
Can map be a string or a RawSourceMap here with a check in the processBundle function to handle either? Sourcemaps can easily be in the megabyte range. Serializing and immediately deserializing can have performance and memory usage concerns.
There was a problem hiding this comment.
Yeah make sense! Done.
|
Also, this will most likely not apply cleanly to 8.3.x so a more minimal change set may be needed for that branch. |
…ES2015 during differential loading When having differential loading enabled we only add the `sourceMappingURL` comment when optimization is enabled, because we only process these bundles when we enabling optimization. With this change we now process such bundles even when optimization is disabled and add `sourceMappingURL` when source maps are enabled and not hidden. Closes #16522
|
Blocking until the LTS version is green. As I am think it might be related to caching. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
…ES2015 during differential loading
When having differential loading enabled we only add the
sourceMappingURLcomment when optimization is enabled, because we only process these bundles when we enabling optimization.With this change we now process such bundles even when optimization is disabled and add
sourceMappingURLwhen source maps are enabled and not hidden.Closes #16522