Skip to content

CLI doesn't allow custom builder to pass additional extensions when building app for i18n extractions #27264

Open

Description

Command

extract-i18n

Description

We're in the process of migrating from webpack to esbuild.
To provide custom esbuild plugins we decided to use custom builder (https://github.com/just-jeb/angular-builders).

It went smooth until we realised that extract-i18 no longer works. It ends successfully but messages.xlf is empty.

It turned out that angular checks builderName to choose which bundler to use.

To fix that I decided to implement custom extract-i18n builder that will trick angular/cli and force using esbuild -
just-jeb/angular-builders#1711

For the record nrwl/nx did the same - nrwl/nx#21802

The issue is that angular/cli will not let us pass any extensions during i18n application compilation.

for await (const result of build(buildOptions as any, context, { write: false })) {

It may lead to inconsistency between build and extract flow, which I suppose may lead to issues with i18n.

Describe the solution you'd like

We should be able to pass custom extensions as for regular app building.

(bonus) would be really nice if these if (builderName === ... are replaced by something that is custom builder friendly 🙏

Describe alternatives you've considered

Alternatively we could rewrite whole extract-i18n builder, but as 95% of the code would be the same - it seems pointless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions