feat(angular): add the extract-i18n executor #21802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leosvelperez
requested review from
FrozenPandaz,
jaysoo,
AgentEnder and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c265d2e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
approved these changes
Feb 14, 2024
isaacplmann
approved these changes
Feb 14, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When running the
@angular-devkit/build-angular:extract-i18nto extract i18n messages while using@nx/angular:applicationor@nx/angular:browser-esbuildexecutors, the extraction completes successfully, but no messages are actually extracted. This happens due to the Angular CLI builder looking for@angular-devkit/build-angular:*builders and performing some logic based on their existence.Expected Behavior
Extracting i18n messages should work correctly when using
@nx/angular:*executors. A new@nx/angular:extract-i18nexecutor is introduced to handle the Nx executors.Related Issue(s)
Fixes #21225