Issue #148 - Add up direction to dropdown rendering.

[JeromeLam]

This addresses issue #148, which relates to how the dropdown displays in the event there isn't enough space to render it fully. An up direction has been added.

I verified the change against demo.html, demo-multi-select.html and the three theme html files.

[gitnik]

big 👍 for getting this in

[brianfeister]

Thanks @JeromeLam, I'll try to take a look soon.

[cyrilf]

Thanks @JeromeLam for this PR ✨
Hope it will be merge soon! 👍

[brianfeister]

Thanks @JeromeLam

[Keirua]

👍 Great !

[LeleDev]

how to disable up direction?

[igorlino]

+1

how to disable up direction? On some circumstances its doing something wrong.

[paynecodes]

This seems to be breaking for me. Perhaps it is for you all too?

The searchInput element is not focused, so opening the dropdown, and beginning to type doesn't work.

The $timeout function seems to be missing a call to now focus() the search input once it has been given the new display property.

$select.searchInput[0].focus();

[brianfeister]

@JeromeLam would love to get some help from you on this feature. There are a number of bugs that seem to have come out of this feature #977, #990, #989, #976, #973, #998 .

[amrsh]

+1; PR for 989 fixes my issue.

[Flightfreak]

Experiencing the same problem. Even when bottom space available is more then top, it still takes a top position.

[igorlino]

Restating what I wrote in #977 (comment).

From usability perspective, its really annoying not to control the direction where things appear.

With the buggy implementation, the version, as it, makes the latest version of ui-select unusable.

The PR #989 fixes the issue of inconsistent behaviour (at least in my design). Although I personally would like to have it configurable.

If this does not get fixed, its better to disable/revert this feature.

[LeleDev]

@igorlino Totally agree

[ramdog]

Agree with @igorlino. I updated to the latest version to get the benefit of some other bug fixes I was facing. While those other bugs indeed have been fixed (nice!), this has made the select unusable for my project. It seems that when it's automatically showing the options above and you are using the multiselect search, the options don't really drop into place above the input nicely. See this screenshot, the blue highlighted item should be just above the input, not floating way up there like that:

Would be great if the "opens-up" thing was an option that could be configured off.

[ManuelPutallaz]

+1

[evillemez]

Yeah, this kinda hurts... also updated for other bug fixes, but now this. I agree that if there isn't an option to disable it, it should probably be reverted.

[oshai]

+1 @evillemez

[tandrianoff]

I'm experiencing the same issue as @ramdog and it has made this unusable for me.

[LeleDev]

ui-select is dead in a broken, inusable state... great, really

[fferraris]

it's not anymore usable, please fix 👍

[dimirc]

@ramdog can you setup a plunker to reproduce this and try solving asap?

[ramdog]

Hey @dimirc - the issue that @igorlino references has an existing one showing the issue:
#977 (comment)

Here it is:
http://plnkr.co/edit/oZCudVaPNc42B7hLYB7j?p=preview

Steps to reproduce

1. Scroll down to the red field
2. Start typing admin2

Note that the selection remains "floated" above.

[dimirc]

@ramdog take a look #1212
Thanks for the demo!
PD: we will merge the PR soon and fix this issue