-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Issue #148 - Add up direction to dropdown rendering. #836
Issue #148 - Add up direction to dropdown rendering. #836
Conversation
…space to render it.
big 👍 for getting this in |
Thanks @JeromeLam, I'll try to take a look soon. |
Thanks @JeromeLam for this PR ✨ |
Thanks @JeromeLam |
Issue #148 - Add up direction to dropdown rendering.
👍 Great ! |
how to disable up direction? |
+1 how to disable up direction? On some circumstances its doing something wrong. |
This seems to be breaking for me. Perhaps it is for you all too? The searchInput element is not focused, so opening the dropdown, and beginning to type doesn't work. The
|
+1; PR for 989 fixes my issue. |
Experiencing the same problem. Even when bottom space available is more then top, it still takes a top position. |
Restating what I wrote in #977 (comment). From usability perspective, its really annoying not to control the direction where things appear. With the buggy implementation, the version, as it, makes the latest version of ui-select unusable. The PR #989 fixes the issue of inconsistent behaviour (at least in my design). Although I personally would like to have it configurable. If this does not get fixed, its better to disable/revert this feature. |
@igorlino Totally agree |
Agree with @igorlino. I updated to the latest version to get the benefit of some other bug fixes I was facing. While those other bugs indeed have been fixed (nice!), this has made the select unusable for my project. It seems that when it's automatically showing the options above and you are using the multiselect search, the options don't really drop into place above the input nicely. See this screenshot, the blue highlighted item should be just above the input, not floating way up there like that: Would be great if the "opens-up" thing was an option that could be configured off. |
+1 |
Yeah, this kinda hurts... also updated for other bug fixes, but now this. I agree that if there isn't an option to disable it, it should probably be reverted. |
+1 @evillemez |
I'm experiencing the same issue as @ramdog and it has made this unusable for me. |
ui-select is dead in a broken, inusable state... great, really |
it's not anymore usable, please fix 👍 |
@ramdog can you setup a plunker to reproduce this and try solving asap? |
Hey @dimirc - the issue that @igorlino references has an existing one showing the issue: Here it is: Steps to reproduce
Note that the selection remains "floated" above. |
This addresses issue #148, which relates to how the dropdown displays in the event there isn't enough space to render it fully. An up direction has been added.
I verified the change against demo.html, demo-multi-select.html and the three theme html files.