Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

BiometricAuthenticator: also allow Class 2 biometric implementations #1046

Merged
merged 1 commit into from
Aug 23, 2020
Merged

BiometricAuthenticator: also allow Class 2 biometric implementations #1046

merged 1 commit into from
Aug 23, 2020

Conversation

msfjarvis
Copy link
Member

@msfjarvis msfjarvis commented Aug 23, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

📜 Description

Allow Class 2 biometric clients as noted in the Android CDD to also use the biometric authentication service. Fixes #1044.

💡 Motivation and Context

A ton of devices ship with weak biometrics and some like Samsung manage to break their strong auth to the point its no better than weak ones. Since BIOMETRIC_WEAK is a superset of BIOMETRIC_STRONG we can instead use BIOMETRIC_WEAK and also be able to use BIOMETRIC_STRONG on devices where its available.

💚 How did you test it?

API 29 devices no longer crash.

📝 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

🔮 Next steps

📸 Screenshots / GIFs

Android OEMs are hellspawn

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis msfjarvis added this to the 1.12.0 milestone Aug 23, 2020
@msfjarvis msfjarvis added the bug label Aug 23, 2020
@fmeum fmeum merged commit 06497f1 into android-password-store:develop Aug 23, 2020
@msfjarvis msfjarvis deleted the biometrics-suck branch August 23, 2020 11:49
msfjarvis added a commit that referenced this pull request Aug 23, 2020
* develop:
  BiometricAuthenticator: also allow Class 2 biometric implementations (#1046)
  BiometricAuthenticator: fix multiple regressions from AndroidX update (#1045)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Crash on startup due to biometric authentication
2 participants