This repository was archived by the owner on Oct 15, 2024. It is now read-only.
BiometricAuthenticator: fix multiple regressions from AndroidX update #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
approved these changes
Aug 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Reconfigure BiometricAuthenticator to bring back the correct set of authentication parameters and fix #1044.
💡 Motivation and Context
During the AndroidX updates from #1039 I misinterpreted the
BiometricManager.Authenticatorsjavadoc and causedthe dialog to only use device credential authentication, which in itself is a problem, and also caused the dialog
to consistently crash. While at it I took some liberty to move things around for readability.
💚 How did you test it?
Verify biometric authentication can be enabled and used with both strong biometrics and device credentials without
crashing.
📝 Checklist
🔮 Next steps
📸 Screenshots / GIFs