sync jmoiron/sqlx #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: types/types.go
1.7 contains this commit golang/go@4e0cd1e which resolves golang/go#13905.
but also the type that is missing that name
better 'missing destination name' error message
JSONText & GzippedText are safe in 1.7
Don't ignore possible gzip error
Allows Go to read and write MySQL BIT(1) type as a bool. This allows you to use 1 bit for a MySQL boolean instead of 1 byte for the standard TINYINT.
Add type BitBool Scanner/Valuer for MySQL type BIT
Don't drop errors in scanAll
Improve placeholder substitution documentation
Information about the Get() errors included in the documentation
Add NullJSONText
The package-level function Get calls the interface method QueryRowx which is expected to return *Row. Implementations of that interface in another package can't possibly set the unexported rows field, so it must be checked for nil before accessing it.
scanAny: add nil check
Add Tx.NamedExecContext method
Fix header in README
[]byte is one of the driver.Value types, and should therefore not be expanded by `In`.
fix README example
If the db open succeeds but the Ping() fails, close the connection and return nil along with the error to prevent resource leakage. Fixes #366
sqlx.Connect: Close db connection if db.Ping() fails
Add and use TraversalsByNameFunc for zero allocation field traversal
… of []byte as the base type for Scanners; a test-only change that has all tests passing again
added support for the cloudsqlpostgres driver
[]byte should not be expanded by In
Added ColumnTypes support
Add missing context enabled functions
As has checked v.Kind above, no need to use indirect to get the value
Simplify get Value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.