JSONText broken

[gravis]

Until recently, JSONText was acting like a string, and since 6708aed, we have a lot of issues with this type.
See the following code:

package main

import (
        "encoding/json"
        "fmt"
        "github.com/jmoiron/sqlx/types"
)

type X struct {
        Z types.JSONText
}

func main() {
        x := X{
                Z: types.JSONText("[]"),
        }
        bytes, _ := json.Marshal(x)
        fmt.Printf("%s\n", string(bytes))
}

before the commit, it was returning {"Z":[]} as expected, and after {"Z":"W10="}

[gravis]

Ok, got it.

// MarshalJSON returns the *j as the JSON encoding of j.
func (j *JSONText) MarshalJSON() ([]byte, error) {
	if len(*j) == 0 {
		*j = _EMPTY_JSON
	}
	return *j, nil
}

should be

// MarshalJSON returns the j as the JSON encoding of j.
func (j JSONText) MarshalJSON() ([]byte, error) {
	if len(j) == 0 {
		j = _EMPTY_JSON
	}
	return j, nil
}

Otherwise the func is never called.

[gravis]

@jmoiron 6708aed is really is breaking change for us, can you take a look at this?
Thanks

[jmoiron]

I don't see a reason to have that mutation in the first place. f9b4c7a passed tests, can you make sure it works for you?

[gravis]

It works!
Thanks a lot :)