Skip to content

Added GMSL MAX96793 and MAX96792 Drivers #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

asewa108
Copy link

Pull Request Description

Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.

PR Type

  • Bug fix (change that fixes an issue)
  • [x ] New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • [x ] I have followed the Coding style guidelines
  • [x ] I have performed a self-review of the changes
  • [x ] I have commented my code, at least hard-to-understand parts
  • [x ] I have build all projects affected by the changes in this PR
  • [x ] I have tested in hardware affected projects, at the relevant boards
  • [x ] I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

@CiprianRegus
Copy link
Contributor

Hi, the comments from #2436 still apply. Also the I have signed off all commits from this PR tick in the PR checklist refers to having the Signed-off-by tag at the end of every commit message. Whether or not you want to sign the commit with a GPG key, that is up to you, but those are different things.

Signed-off-by: asewa108 <angu.sewa@analog.com>
…ewa108/no-OS into GMSL_MAX96793_MAX96792_Public_Drivers
@asewa108
Copy link
Author

Hi, the comments from #2436 still apply. Also the I have signed off all commits from this PR tick in the PR checklist refers to having the Signed-off-by tag at the end of every commit message. Whether or not you want to sign the commit with a GPG key, that is up to you, but those are different things.

Done Signed-off-by.

@buha
Copy link
Contributor

buha commented Feb 21, 2025

we don't allow "Merged..." kind of commits to not pollute the history, please use git rebase -i function to squash or edit commits. And git rebase to rebase instead of merge.

@buha
Copy link
Contributor

buha commented Feb 21, 2025

also, why did you close the other pull request ? i had some comments there and now it's hard to track the comment history

@asewa108
Copy link
Author

also, why did you close the other pull request ? i had some comments there and now it's hard to track the comment history

PR #2436 had unresolvable issue with CLA, so closed it and raised this.

@kister-jimenez
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@asewa108 asewa108 marked this pull request as draft April 9, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants