-
Notifications
You must be signed in to change notification settings - Fork 1.7k
GMSL MAX96792 MAX96793 Drivers and sample project #2436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMSL MAX96792 MAX96793 Drivers and sample project #2436
Conversation
ASewa seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@@ -0,0 +1,10 @@ | |||
# Select the example you want to enable by choosing y and disable others by choosing n. | |||
|
|||
CFG_DIAG_MAX96792_MAX96793_UC_EX = y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use the new EXAMPLE=max96792_max96793_example
infrastructure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
click on any commit of this PR to see what you need to change:
#2420
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also separate the driver changes from the project changes, make 2 separate commits (or more if needed) |
Make sure to click the CLA Assistant button to sign the agreement, I think this is needed because you're contributing from your personal github account/email. |
also, please don't add "fixed this or that" kind of commits separately, you should squash them into the relevant commits as it stands it seems to me you need one commit with gmsl infrastructure (what you put in drivers/common), a 2nd commit with the serializer, a 3rd with the deserializer and a 4th one with the project |
I would say go ahead and fix the above remarks and we can have another round of review on the code itself. |
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist
This PR adds GMSL drivers for MAX96792 Deserializer and MAX96793 Serializer along with a sample use-case project.