Skip to content

GMSL MAX96792 MAX96793 Drivers and sample project #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

asewa108
Copy link

@asewa108 asewa108 commented Feb 6, 2025

Pull Request Description

Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

This PR adds GMSL drivers for MAX96792 Deserializer and MAX96793 Serializer along with a sample use-case project.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


ASewa seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -0,0 +1,10 @@
# Select the example you want to enable by choosing y and disable others by choosing n.

CFG_DIAG_MAX96792_MAX96793_UC_EX = y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the new EXAMPLE=max96792_max96793_example infrastructure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

click on any commit of this PR to see what you need to change:
#2420

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asewa108 this is another example project that is following this structure. #2459. You can also follow how the commits subjects and body were created. You can use git rebase -i and edit.

@buha
Copy link
Contributor

buha commented Feb 6, 2025

also separate the driver changes from the project changes, make 2 separate commits (or more if needed)

@buha
Copy link
Contributor

buha commented Feb 6, 2025

Make sure to click the CLA Assistant button to sign the agreement, I think this is needed because you're contributing from your personal github account/email.

@buha
Copy link
Contributor

buha commented Feb 6, 2025

also, please don't add "fixed this or that" kind of commits separately, you should squash them into the relevant commits

as it stands it seems to me you need one commit with gmsl infrastructure (what you put in drivers/common), a 2nd commit with the serializer, a 3rd with the deserializer and a 4th one with the project

@buha
Copy link
Contributor

buha commented Feb 6, 2025

I would say go ahead and fix the above remarks and we can have another round of review on the code itself.

@asewa108 asewa108 closed this Feb 20, 2025
@asewa108 asewa108 deleted the GMSL_MAX96792_MAX96793_Drivers branch February 20, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants