dt-bindings: soc: adi: Add SC5XX SoC component bindings #3033
Conversation
artursartamonovsadi
requested review from
CalebEthridgeADI,
UtsavAgarwalADI,
jiez,
nunojsa,
ozan956,
pamolloy and
vasbimpikasadi
Documentation/devicetree/bindings/soc/adi/adi,pads-system-config.yaml
Outdated
Show resolved
Hide resolved
Documentation/devicetree/bindings/soc/adi/adi,system-event-controller.yaml
Outdated
Show resolved
Hide resolved
|
@artursartamonovsadi don't worry about the builds succeeding but please take a look at the "checks": https://github.com/analogdevicesinc/linux/actions/runs/19863355918/job/56919188243?pr=3033 |
|
device-tree binding checks are passing |
| - Arturs Artamonovs <arturs.artamonovs@analog.com> | ||
| - Utsav Agarwal <Utsav.Agarwal@analog.com> | ||
|
|
||
| description: | |
There was a problem hiding this comment.
In practice, no need for pre-formatting
| ... | ||
| adi,system-config = <&pads_system_config>; | ||
| ... | ||
| }; No newline at end of file |
There was a problem hiding this comment.
Just to note (it seems this is not the case). The preferred style for indentation in the DT example are 4 spaces
|
|
||
| adi,sharc-max: | ||
| $ref: /schemas/types.yaml#/definitions/uint32 | ||
| description: "Maximum valid SHARC core ID/count" |
There was a problem hiding this comment.
no constrains? Can we have the full unsigned int range?
There was a problem hiding this comment.
I will limit it to 2 cores
| reg: | ||
| maxItems: 1 | ||
|
|
||
| "adi,rcu": |
|
|
||
| "adi,sharc-cores": | ||
| $ref: /schemas/types.yaml#/definitions/uint32 | ||
| description: "Number of SHARC cores available" |
There was a problem hiding this comment.
Same comment about constrains. I guess we have a limited number of cores 😉
| "adi,tru-slave-id": | ||
| description: Trigger Routing Slave ID | ||
| minItems: 1 | ||
| maxItems: 1 |
There was a problem hiding this comment.
I think you only need minItems: 1. Then maxItems defaults to 1...
| oneOf: | ||
| - items: | ||
| - enum: | ||
| - adi,pads-system-config |
There was a problem hiding this comment.
Why? Keep the original please
| oneOf: | ||
| - items: | ||
| - enum: | ||
| - adi,system-event-controller |
| adi,max-slave-id = <187>; | ||
| }; | ||
| &tru { |
There was a problem hiding this comment.
Ahh I see. The fixup commits are not very helpful for reviewing
There was a problem hiding this comment.
Should I merge them then and just to have single commit?
There was a problem hiding this comment.
Yup, fixup commits are helpful for development, but should be squashed before review and merge. A PR really shouldn't be approved with fixup commits. And the DCO workflow also doesn't seem to handle it
There was a problem hiding this comment.
The re-review button in the Reviewers section at the top left of the PR is also super helpful after you've made a bunch of updates to notify folks
|
We discussed during the meeting yesterday, but it would be good to convert the txt to yaml. Can you also update MAINTAINERS appropriately? |
Agreed! It's work that will be needed anyways so better to do it now. |
Hi, I prefer the scope of PR to stay within devicetree bindings, there is no maintainers defined in this adsp-main-6.12 branches, so far. But MAINTAINERS defined in upstreaming patch series. Maybe better to open separate PR, with complete MAINTAINERS list, rather in single PR we can try to fix all the issues. |
artursartamonovsadi
force-pushed
the
adsp-main-6.12-devicetree-soc
branch
from
e70e148 to
17ae7c8
Compare
|
@nunojsa I have left one "|" in adi,rpmsg-SC598.yaml description as if I remove it I get this error from dt binding check: |
Document device tree bindings for ADI SC5XX SoC components including PADS config, reset controller, system event controller, trigger routing unit, and RPMSG support. Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
artursartamonovsadi
force-pushed
the
adsp-main-6.12-devicetree-soc
branch
from
91c267a to
ffd6b12
Compare
Document device tree bindings for ADI SC5XX SoC components including
PADS config, reset controller, system event controller, trigger routing
unit, and RPMSG support.
Ported files from 5.15.x lnxdsp-linux repo
PR Type
PR Checklist