Skip to content

Conversation

@JRabacca
Copy link

@JRabacca JRabacca commented Sep 24, 2025

PR Description

Adapted the HDL files from AD9467 Zedboard to AD9467 ZCU102.
Previously it had no prior support.
Unsure of any code style guidelines, but files were copied from existing examples and were modified as needed.
To be merged together with the Linux PR analogdevicesinc/linux#2957.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2025

CLA assistant check
All committers have signed the CLA.

@JRabacca
Copy link
Author

I've been informed that the 2023_R2 branch isn't usually edited.
I'll redo changes using the fork of main branch.

@JRabacca JRabacca closed this Sep 24, 2025
@JRabacca
Copy link
Author

Reopened. Closed the wrong pull request. Previous comment was for the linux repository

@JRabacca JRabacca reopened this Sep 24, 2025
@IuliaCMoldovan IuliaCMoldovan changed the title Ad9467 zcu102 projects/ad9467_fmc: Add support on ZCU102 Sep 24, 2025
IuliaCMoldovan
IuliaCMoldovan previously approved these changes Nov 5, 2025
Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the HDL point of view, all is ok. You can squash the commits to arrange them a bit. Now waiting for approval on Linux side, and when that is approved, we should merge them in the same day.

@sarpadi sarpadi self-requested a review November 5, 2025 11:13
@JRabacca JRabacca force-pushed the ad9467_zcu102 branch 4 times, most recently from a2a0038 to aa8ae61 Compare November 7, 2025 02:13
Signed-off-by: JuanRafael Rabacca <rafael.rabacca@gmail.com>
Signed-off-by: JuanRafael Rabacca <rafael.rabacca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants