Skip to content

Let hermite end at exactly the requested time by default #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rieder merged 2 commits into from
Jan 24, 2024
Merged

Let hermite end at exactly the requested time by default #1028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dc9cd0
set default value of hermite.parameters.end_time_accuracy_factor from…
spzwart Jan 24, 2024
5252fe5
Merge branch 'main' into patch/hermite
rieder Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/amuse/community/hermite/interface.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ static real t_evolve = t; // Time requested by evolve. Control r
// system is computed by extrapolation.
static real t_wanted = 0;
static double begin_time = 0;
static double end_time_accuracy_factor = 0.5;
static double end_time_accuracy_factor = 0.0;

static vector<int> ident;
static vector<real> mass, radius, potential;
Expand Down
2 changes: 1 addition & 1 deletion src/amuse/community/hermite/interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ def define_parameters(self, handler):

Valid factors are between -1.0 and 1.0
""",
default_value = 1.0
default_value = 0.0
)
handler.add_method_parameter(
"get_dt_dia",
Expand Down