Skip to content

Conversation

@rieder
Copy link
Member

@rieder rieder commented Jan 24, 2024

set default value of hermite.parameters.end_time_accuracy_factor from 0.5 to 0.0

@rieder rieder requested a review from a team as a code owner January 24, 2024 11:08
@rieder
Copy link
Member Author

rieder commented Jan 24, 2024

Pro: Hermite will stop at exactly the expected time.
Con: Hermite will give different results depending on how many evolve steps are taken.

The former seems more important as the default.

@rieder rieder merged commit 044ca1f into main Jan 24, 2024
@rieder rieder deleted the patch/hermite branch January 24, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants