Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor output #929

Merged
merged 10 commits into from
Sep 8, 2020
Merged

Refactor output #929

merged 10 commits into from
Sep 8, 2020

Conversation

kristoferbaxter
Copy link
Contributor

Move to amp-debug and amp-production outputs.

@google-cla google-cla bot added the cla: yes label Sep 3, 2020
@erwinmombay erwinmombay mentioned this pull request Sep 3, 2020
Closed
samouri
samouri requested changes Sep 3, 2020
View reviewed changes
Copy link
Member

@samouri samouri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We also need to update some of the filesize checks (and add the ones that don't exist yet. This is something I had missed when adding nodom).

I'd be happy to update it in a followup PR if you'd rather keep em separate

config/rollup.main-thread.js
terser(),
],
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: we don't currently have the setup to be able to switch to main-thread debug variant (1), but this would be nice to add.

config/rollup.worker-thread.js
format: 'iife',
name: 'WorkerThread',
sourcemap: true,
banner: 'var WORKER_DOM_DEBUG = /log|development/i.test(location.hash);',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to see this go away :). We'll need to pick the correct one based on dev/prod builds.

@kristoferbaxter
Copy link
Contributor Author

Added tracking for the nodom variant.

This was referenced Sep 8, 2020
Merged
Closed
@kristoferbaxter kristoferbaxter merged commit 70754dd into main Sep 8, 2020
@kristoferbaxter kristoferbaxter deleted the refactor-output branch September 8, 2020 16:11
valleykid added a commit to icatjs/worker-dom that referenced this pull request Sep 9, 2020
@valleykid @samouri
@morsssss @renovate-bot @kristoferbaxter
feat: sync from base-source (#1)
fe45972 
* update to latest version of np (ampproject#915)

* update to latest version of np

* also update jsdom, some strange errors occuring with whatwg-url

* Mention that innerHTML has partial support (ampproject#911)

* Pin dependency jsdom to 16.4.0 (ampproject#916)

* Update Yarn to v1.22.5 (ampproject#918)

* Update dependency rollup-plugin-terser to v7 (ampproject#907)

* Update dependency rollup to v2.26.8 (ampproject#899)

* Update dependency acorn-walk to v8 (ampproject#922)

* HTMLElement.click() support (ampproject#919)

* HTMLElement: Support .click() function.

* HTMLElement.click() support

* update web compat table.

* Update dependency acorn to v8 (ampproject#908)

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>

* Update dependency typescript to v4 (ampproject#923)

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>

* Update dependency np to v6.5.0 (ampproject#921)

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>

* Support Dirty Flag for HTMLInputElement.value (ampproject#913)

* v0.25.1

* Support dirty flag for HTMLInputElement.value

* Support dirty flag for HTMLInputElement.value

* add a test

* fix progress

* update test for progress as well

* Bump size of worker.mjs

* Remove populated demo examples since tests now cover the functionality

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>

* Update Node.js to v14.9.0 (ampproject#889)

* v0.26.0 (ampproject#925)

* Update dependency rollup to v2.26.9 (ampproject#924)

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>
Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency prettier to v2.1.1 (ampproject#920)

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>
Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency css-loader to v4 (ampproject#906)

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency webpack-cli to v3.3.12 (ampproject#905)

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency webpack to v4.44.1 (ampproject#904)

* Update dependency tslint to v6.1.3 (ampproject#902)

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Remove esmodule syntax (ampproject#927)

* v0.25.1

* Remove ESModules Package syntax since its not being used

* Use toUpper utility (ampproject#928)

* v0.25.1

* Use the utilities instead of direct methods

* Update dependency sirv to v1.0.6 (ampproject#901)

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency sinon to v9.0.3 (ampproject#900)

* Update dependency rollup to v2.26.11 (ampproject#931)

* Update dependency css-loader to v4.3.0 (ampproject#934)

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>

* Refactor output (ampproject#929)

* v0.25.1

* Create production and debug outputs for AMP

* tweak tracked resources for filesize

* Additional tracking for nodom variant

* Update dependency husky to v4.3.0 (ampproject#933)

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>

* Update Dependencies (ampproject#935)

* v0.25.1

* Update to latest versions

* Bump version + skip hooks for release (ampproject#936)

* v0.27.0

* skip hooks on release

* v0.27.1

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update Node.js to v14.10.0 (ampproject#930)

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency preact to v10.4.8 (ampproject#898)

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency mini-css-extract-plugin to v0.11.1 (ampproject#897)

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency ava to v3.12.1 (ampproject#893)

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>
Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency lint-staged to v10.3.0 (ampproject#896)

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>
Co-authored-by: Ben Morss <morss@google.com>
Co-authored-by: WhiteSource Renovate <bot@renovateapp.com>
Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>
@valleykid valleykid mentioned this pull request Sep 9, 2020
Merged
valleykid added a commit to icatjs/worker-dom that referenced this pull request Sep 9, 2020
@valleykid @samouri
@morsssss @renovate-bot @kristoferbaxter
feat: sync from base-source by sync-branch (#2)
b3a8055 
* feat: sync from base-source (#1)

* update to latest version of np (ampproject#915)

* update to latest version of np

* also update jsdom, some strange errors occuring with whatwg-url

* Mention that innerHTML has partial support (ampproject#911)

* Pin dependency jsdom to 16.4.0 (ampproject#916)

* Update Yarn to v1.22.5 (ampproject#918)

* Update dependency rollup-plugin-terser to v7 (ampproject#907)

* Update dependency rollup to v2.26.8 (ampproject#899)

* Update dependency acorn-walk to v8 (ampproject#922)

* HTMLElement.click() support (ampproject#919)

* HTMLElement: Support .click() function.

* HTMLElement.click() support

* update web compat table.

* Update dependency acorn to v8 (ampproject#908)

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>

* Update dependency typescript to v4 (ampproject#923)

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>

* Update dependency np to v6.5.0 (ampproject#921)

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>

* Support Dirty Flag for HTMLInputElement.value (ampproject#913)

* v0.25.1

* Support dirty flag for HTMLInputElement.value

* Support dirty flag for HTMLInputElement.value

* add a test

* fix progress

* update test for progress as well

* Bump size of worker.mjs

* Remove populated demo examples since tests now cover the functionality

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>

* Update Node.js to v14.9.0 (ampproject#889)

* v0.26.0 (ampproject#925)

* Update dependency rollup to v2.26.9 (ampproject#924)

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>
Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency prettier to v2.1.1 (ampproject#920)

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>
Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency css-loader to v4 (ampproject#906)

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency webpack-cli to v3.3.12 (ampproject#905)

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency webpack to v4.44.1 (ampproject#904)

* Update dependency tslint to v6.1.3 (ampproject#902)

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Remove esmodule syntax (ampproject#927)

* v0.25.1

* Remove ESModules Package syntax since its not being used

* Use toUpper utility (ampproject#928)

* v0.25.1

* Use the utilities instead of direct methods

* Update dependency sirv to v1.0.6 (ampproject#901)

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency sinon to v9.0.3 (ampproject#900)

* Update dependency rollup to v2.26.11 (ampproject#931)

* Update dependency css-loader to v4.3.0 (ampproject#934)

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>

* Refactor output (ampproject#929)

* v0.25.1

* Create production and debug outputs for AMP

* tweak tracked resources for filesize

* Additional tracking for nodom variant

* Update dependency husky to v4.3.0 (ampproject#933)

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>

* Update Dependencies (ampproject#935)

* v0.25.1

* Update to latest versions

* Bump version + skip hooks for release (ampproject#936)

* v0.27.0

* skip hooks on release

* v0.27.1

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update Node.js to v14.10.0 (ampproject#930)

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency preact to v10.4.8 (ampproject#898)

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency mini-css-extract-plugin to v0.11.1 (ampproject#897)

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency ava to v3.12.1 (ampproject#893)

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>
Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* Update dependency lint-staged to v10.3.0 (ampproject#896)

Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>
Co-authored-by: Ben Morss <morss@google.com>
Co-authored-by: WhiteSource Renovate <bot@renovateapp.com>
Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>

* fix: package.json conflict

Co-authored-by: Jake Fried <samouri@users.noreply.github.com>
Co-authored-by: Ben Morss <morss@google.com>
Co-authored-by: WhiteSource Renovate <bot@renovateapp.com>
Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>
@kristoferbaxter kristoferbaxter mentioned this pull request Sep 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samouri samouri samouri approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristoferbaxter @samouri