Support Dirty Flag for HTMLInputElement.value #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this fixes #913 |
|
Seems to be an issue with the
|
|
We've been relying on a custom version of |
|
Attempting to update here: #915, if that goes through I'll rebase this branch. |
samouri
force-pushed
the
dirty-flag-value
branch
from
e10f2ec to
9722b69
Compare
|
@kristoferbaxter: this is ready for a review when you have time. Not sure if you intended to merge the new demo files or were just using them for manual testing, my preference would be to delete before a merge. Note: no idea if its possible for you to review/accept your own PR :). It should really be possible for someone else to "commandeer" a PR. |
samouri
approved these changes
Aug 26, 2020
|
Looks like we went over the size limit, taking a look. |
valleykid
added a commit
to icatjs/worker-dom
that referenced
this pull request
Sep 9, 2020
* update to latest version of np (ampproject#915) * update to latest version of np * also update jsdom, some strange errors occuring with whatwg-url * Mention that innerHTML has partial support (ampproject#911) * Pin dependency jsdom to 16.4.0 (ampproject#916) * Update Yarn to v1.22.5 (ampproject#918) * Update dependency rollup-plugin-terser to v7 (ampproject#907) * Update dependency rollup to v2.26.8 (ampproject#899) * Update dependency acorn-walk to v8 (ampproject#922) * HTMLElement.click() support (ampproject#919) * HTMLElement: Support .click() function. * HTMLElement.click() support * update web compat table. * Update dependency acorn to v8 (ampproject#908) Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * Update dependency typescript to v4 (ampproject#923) Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * Update dependency np to v6.5.0 (ampproject#921) Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * Support Dirty Flag for HTMLInputElement.value (ampproject#913) * v0.25.1 * Support dirty flag for HTMLInputElement.value * Support dirty flag for HTMLInputElement.value * add a test * fix progress * update test for progress as well * Bump size of worker.mjs * Remove populated demo examples since tests now cover the functionality Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * Update Node.js to v14.9.0 (ampproject#889) * v0.26.0 (ampproject#925) * Update dependency rollup to v2.26.9 (ampproject#924) Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency prettier to v2.1.1 (ampproject#920) Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency css-loader to v4 (ampproject#906) Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency webpack-cli to v3.3.12 (ampproject#905) Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency webpack to v4.44.1 (ampproject#904) * Update dependency tslint to v6.1.3 (ampproject#902) Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Remove esmodule syntax (ampproject#927) * v0.25.1 * Remove ESModules Package syntax since its not being used * Use toUpper utility (ampproject#928) * v0.25.1 * Use the utilities instead of direct methods * Update dependency sirv to v1.0.6 (ampproject#901) Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency sinon to v9.0.3 (ampproject#900) * Update dependency rollup to v2.26.11 (ampproject#931) * Update dependency css-loader to v4.3.0 (ampproject#934) Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * Refactor output (ampproject#929) * v0.25.1 * Create production and debug outputs for AMP * tweak tracked resources for filesize * Additional tracking for nodom variant * Update dependency husky to v4.3.0 (ampproject#933) Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * Update Dependencies (ampproject#935) * v0.25.1 * Update to latest versions * Bump version + skip hooks for release (ampproject#936) * v0.27.0 * skip hooks on release * v0.27.1 Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update Node.js to v14.10.0 (ampproject#930) Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency preact to v10.4.8 (ampproject#898) Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency mini-css-extract-plugin to v0.11.1 (ampproject#897) Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency ava to v3.12.1 (ampproject#893) Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency lint-staged to v10.3.0 (ampproject#896) Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: Ben Morss <morss@google.com> Co-authored-by: WhiteSource Renovate <bot@renovateapp.com> Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>
valleykid
added a commit
to icatjs/worker-dom
that referenced
this pull request
Sep 9, 2020
* feat: sync from base-source (#1) * update to latest version of np (ampproject#915) * update to latest version of np * also update jsdom, some strange errors occuring with whatwg-url * Mention that innerHTML has partial support (ampproject#911) * Pin dependency jsdom to 16.4.0 (ampproject#916) * Update Yarn to v1.22.5 (ampproject#918) * Update dependency rollup-plugin-terser to v7 (ampproject#907) * Update dependency rollup to v2.26.8 (ampproject#899) * Update dependency acorn-walk to v8 (ampproject#922) * HTMLElement.click() support (ampproject#919) * HTMLElement: Support .click() function. * HTMLElement.click() support * update web compat table. * Update dependency acorn to v8 (ampproject#908) Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * Update dependency typescript to v4 (ampproject#923) Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * Update dependency np to v6.5.0 (ampproject#921) Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * Support Dirty Flag for HTMLInputElement.value (ampproject#913) * v0.25.1 * Support dirty flag for HTMLInputElement.value * Support dirty flag for HTMLInputElement.value * add a test * fix progress * update test for progress as well * Bump size of worker.mjs * Remove populated demo examples since tests now cover the functionality Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * Update Node.js to v14.9.0 (ampproject#889) * v0.26.0 (ampproject#925) * Update dependency rollup to v2.26.9 (ampproject#924) Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency prettier to v2.1.1 (ampproject#920) Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency css-loader to v4 (ampproject#906) Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency webpack-cli to v3.3.12 (ampproject#905) Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency webpack to v4.44.1 (ampproject#904) * Update dependency tslint to v6.1.3 (ampproject#902) Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Remove esmodule syntax (ampproject#927) * v0.25.1 * Remove ESModules Package syntax since its not being used * Use toUpper utility (ampproject#928) * v0.25.1 * Use the utilities instead of direct methods * Update dependency sirv to v1.0.6 (ampproject#901) Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency sinon to v9.0.3 (ampproject#900) * Update dependency rollup to v2.26.11 (ampproject#931) * Update dependency css-loader to v4.3.0 (ampproject#934) Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * Refactor output (ampproject#929) * v0.25.1 * Create production and debug outputs for AMP * tweak tracked resources for filesize * Additional tracking for nodom variant * Update dependency husky to v4.3.0 (ampproject#933) Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * Update Dependencies (ampproject#935) * v0.25.1 * Update to latest versions * Bump version + skip hooks for release (ampproject#936) * v0.27.0 * skip hooks on release * v0.27.1 Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update Node.js to v14.10.0 (ampproject#930) Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency preact to v10.4.8 (ampproject#898) Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency mini-css-extract-plugin to v0.11.1 (ampproject#897) Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency ava to v3.12.1 (ampproject#893) Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * Update dependency lint-staged to v10.3.0 (ampproject#896) Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: Ben Morss <morss@google.com> Co-authored-by: WhiteSource Renovate <bot@renovateapp.com> Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com> * fix: package.json conflict Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: Ben Morss <morss@google.com> Co-authored-by: WhiteSource Renovate <bot@renovateapp.com> Co-authored-by: Kristofer Baxter <kristofer@kristoferbaxter.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrates how to fix this issue by relying on the
Attributebefore the setter was called on theProperty.Likely we should have a generic pattern for this.