Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some requirements of SXG payload #452

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Remove some requirements of SXG payload #452

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15fd6ec
Remove the requirement of SXG payload
caoboxiao Jul 13, 2020
d0956bb
Remove the utf-8 requirement of SXG payload
caoboxiao Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions docs/cache_requirements.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,12 @@ These include:
* Parameter values of type string, binary, or identifier.
* The payload must be:
* non-empty.
* well-formed UTF-8 that doesn't contain:
* any characters that cause a parse-error during [HTML preprocessing](https://html.spec.whatwg.org/multipage/parsing.html#preprocessing-the-input-stream)
* U+0000 NULL
* valid transformed AMP. The canonical definition of transformed AMP is the
return value of [`transform.Process()`](https://github.com/ampproject/amppackager/blob/e4bf0430ba152cfe82ccf063df92021dfc0f26a5/transformer/transformer.go#L219).
If given a [valid AMP](https://github.com/ampproject/amphtml/tree/master/validator)
doc as input, it should produce a valid transformed AMP doc. There may be
other ways of achieving this, but they are unsupported (i.e. may
arbitrarily break in the future).
* unchanged after calling [`transform -config NONE`](https://github.com/ampproject/amppackager/tree/releases/transformer#how-to-use).
* matching one of the versions requested by the `AMP-Cache-Transform` header.
Note that this version range will increase over time, at a cadence TBD
(likely 6-8 weeks with 2 or 3 supported latest versions).
Expand Down