Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some requirements of SXG payload #452

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Conversation

caoboxiao
Copy link
Contributor

Update the document and remove the requirement of Google AMP cache
SXG payload to be unchanged after transform.

Update the document and remove the requirement of Google AMP cache
SXG payload to be unchanged after transform.
@twifkak
Copy link
Member

twifkak commented Jul 13, 2020

Hi @caoboxiao! Might as well also remove

* well-formed UTF-8 that doesn't contain:
* any characters that cause a parse-error during [HTML preprocessing](https://html.spec.whatwg.org/multipage/parsing.html#preprocessing-the-input-stream)
* U+0000 NULL
since that is also obviated by http://cl/320958457.

Update the document and remove the utf-8 related requirement of
Google AMP cache SXG payload
@caoboxiao caoboxiao changed the title Remove the requirement of SXG payload Remove some requirements of SXG payload Jul 13, 2020
@caoboxiao
Copy link
Contributor Author

Done.
The utf-8 related requirement of SXG payload is no longer needed.

Hi @caoboxiao! Might as well also remove

* well-formed UTF-8 that doesn't contain:
* any characters that cause a parse-error during [HTML preprocessing](https://html.spec.whatwg.org/multipage/parsing.html#preprocessing-the-input-stream)
* U+0000 NULL

since that is also obviated by http://cl/320958457.

Copy link
Member

@twifkak twifkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent you an invite for write access on this repo. As soon as you accept, you can squash and merge (per our policy).

@caoboxiao caoboxiao merged commit 6473ccf into ampproject:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants