Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Mustache service for Bento standalone components #37584

Merged
merged 17 commits into from
Feb 11, 2022
Merged

✨ Mustache service for Bento standalone components #37584

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
dacab2f
initial commit
dmanek Feb 4, 2022
1ac8e88
add web-component.js & bento-date-display.js
dmanek Feb 4, 2022
74ca325
changes for bento-date-countdown
dmanek Feb 4, 2022
2e366fd
Merge branch 'main' into bento-mustache
dmanek Feb 7, 2022
b7c23f5
add template-utils.js
dmanek Feb 7, 2022
1d1a9ec
Merge branch 'main' into bento-mustache
dmanek Feb 7, 2022
346294f
delete extensions/amp-mustache/1.0/bento-mustache.js
dmanek Feb 7, 2022
4f24260
Apply suggestions from code review
dmanek Feb 7, 2022
6a8261e
address code review comments
dmanek Feb 7, 2022
77c246a
Merge branch 'main' into bento-mustache
dmanek Feb 7, 2022
c36b926
Update src/bento/components/bento-mustache/1.0/bento-mustache.js
dmanek Feb 8, 2022
53ecb67
verify that fetched template is actually a <template>
dmanek Feb 8, 2022
4bb3f8d
fix failed check
dmanek Feb 8, 2022
876ebd6
fix failed checks
dmanek Feb 8, 2022
03d4319
Update src/bento/util/template.js
dmanek Feb 9, 2022
084a1c5
update jsdoc
dmanek Feb 10, 2022
1fe93c2
Merge branch 'main' into bento-mustache
dmanek Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix failed check
  • Loading branch information
@dmanek
dmanek committed Feb 8, 2022
commit 4bb3f8d587f22429224752ced0ae0724965b762b
8 changes: 6 additions & 2 deletions src/bento/util/template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
import {escapeCssSelectorIdent} from '#core/dom/css-selectors';

/**
* @param {HTMLElement} element
* @return {HTMLTemplateElement|null}
*/
export function getTemplate(element) {
if (element.hasAttribute('template')) {
const id = element.getAttribute('template')
return element.ownerDocument.querySelector(`template#${id}`);
const id = element.getAttribute('template');
return Boolean(id) ? element.ownerDocument.querySelector(
`template#${escapeCssSelectorIdent(id)}`
) : null;
}
return element.querySelector('template');
}