Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Mustache service for Bento standalone components #37584

Merged
merged 17 commits into from
Feb 11, 2022
Merged

✨ Mustache service for Bento standalone components #37584

merged 17 commits into from
Feb 11, 2022

Conversation

dmanek
Copy link
Contributor

@dmanek dmanek commented Feb 4, 2022 •
edited
Loading

Fixes #36619

@dmanek dmanek requested review from kvchari and alanorozco February 5, 2022 00:28
alanorozco
alanorozco reviewed Feb 7, 2022
View reviewed changes
@dmanek dmanek requested review from alanorozco and kvchari February 7, 2022 22:38
@dmanek dmanek changed the title Bento mustache Mustache service for Bento standalone components Feb 8, 2022
@dmanek dmanek changed the title Mustache service for Bento standalone components ✨ Mustache service for Bento standalone components Feb 8, 2022
@dmanek
Copy link
Contributor Author

dmanek commented Feb 8, 2022

FYI @scottrippey & @becca-bailey

@dmanek dmanek marked this pull request as ready for review February 8, 2022 16:52
alanorozco
alanorozco approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@alanorozco alanorozco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmanek Could you please update the READMEs? Add the bento-mustache <script> (it 404s for now, that's okay)

@dmanek
Copy link
Contributor Author

dmanek commented Feb 8, 2022

@alanorozco #37604 for updating READMEs is WIP.

@dmanek @scottrippey
Update src/bento/util/template.js
03d4319 
Co-authored-by: Scott Rippey <scottrippey@users.noreply.github.com>
@dmanek dmanek enabled auto-merge (squash) February 11, 2022 18:12
@dmanek dmanek merged commit 6f88c91 into main Feb 11, 2022
@dmanek dmanek deleted the bento-mustache branch February 11, 2022 19:06
@ampprojectbot ampprojectbot mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanorozco alanorozco alanorozco approved these changes

@scottrippey scottrippey scottrippey requested changes

@jridgewell jridgewell jridgewell approved these changes

@kvchari kvchari kvchari approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strategy for rendering from user-provided templates on Bento standalone
6 participants
@dmanek @jridgewell @alanorozco @scottrippey @kvchari @ampprojectbot