🏗 custom-elements-polyfill.js is now bento.js, and async
#36431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @westonruter, @ediamin! These files were changed: |
|
Is Bento the only current consumer of the CE Polyfill binary? |
samouri
reviewed
Oct 20, 2021
samouri
reviewed
Oct 20, 2021
|
Is there documentation that needs to change as well? Do you plan on doing that in this PR or in a separate one? |
|
@samouri I updated all documentation in this repo. If there's some other place where I should change it please let me know. |
Yep |
kvchari
approved these changes
Oct 20, 2021
rsimha
reviewed
Oct 20, 2021
rsimha
approved these changes
Oct 20, 2021
samouri
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #36421
This provides
bento.jsand alias it ascustom-elements-polyfill.jsfor backwards compat.It also allows
bento.jsto be used asasync, which is why we provideself.BENTOand wrap extensions so that they push to it.This change does not yet move shared dependencies into
bento.js.