Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Use correct suffix for renovate-approve bot #34211

Merged
merged 1 commit into from
May 4, 2021
Merged

🏗 Use correct suffix for renovate-approve bot #34211

merged 1 commit into from
May 4, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented May 4, 2021

We use the renovate-approve app to auto-approve low-risk package upgrade PRs that have otherwise passed all other CI checks. In order to allow this, owners bot needs to be satisfied that the bot account is listed in reviewerPool.

From looking at the review payload on GitHub, the renovate-approve account shows up with a [bot] suffix. This PR adds that suffix to the entry in reviewerPool so owners bot recognizes it.

image

Partial fix for #33959

@rsimha rsimha requested review from jridgewell and rcebulko May 4, 2021 19:49
@rsimha rsimha self-assigned this May 4, 2021
@rcebulko
Copy link
Contributor

rcebulko commented May 4, 2021

I believe this will fail amp check-owners until the Owners Bot validation schema is updated

@rsimha
Copy link
Contributor Author

rsimha commented May 4, 2021

I believe this will fail amp check-owners until the Owners Bot validation schema is updated

Will rerun the check on this PR after ampproject/amp-github-apps#1287 has been deployed.

Edit: Done. Logs here.

@rsimha rsimha merged commit 8dbd2ae into ampproject:main May 4, 2021
@rsimha rsimha deleted the 2021-05-04-BotAccount branch May 4, 2021 21:48
rochapablo pushed a commit to rochapablo/amphtml that referenced this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants