Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[owners] Allow bots to be listed in reviewerPool #1287

Merged
merged 2 commits into from
May 4, 2021
Merged

[owners] Allow bots to be listed in reviewerPool #1287

merged 2 commits into from
May 4, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented May 4, 2021

PR Highlights:

  • Add a new Bot definition to schema.json (same as User, but ends in [bot])
  • Update OWNERS.example
  • Update tests in parser.test.js
  • Bonus: Fix outdated WG name and lines longer than 80 chars in OWNERS.example

Required by ampproject/amphtml#34211

@rsimha rsimha requested a review from rcebulko May 4, 2021 20:34
@rsimha rsimha self-assigned this May 4, 2021
@rsimha rsimha mentioned this pull request May 4, 2021
Merged
rcebulko
rcebulko approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@rcebulko rcebulko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock

@rsimha rsimha merged commit b20ee3e into ampproject:main May 4, 2021
@rsimha rsimha deleted the 2021-05-04-BotReviewers branch May 4, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcebulko rcebulko rcebulko approved these changes

Assignees

@rsimha rsimha

Labels
Category: Owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsimha @rcebulko