✨ Ads RTC: support amp-script fetching #33872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
changed the title
|
This pull request introduces 1 alert when merging 78bd4f7 into d5de7fc - view on LGTM.com new alerts:
|
samouri
force-pushed
the
adscript
branch
4 times, most recently
from
d8932bc to
8d84f48
Compare
samouri
commented
Apr 20, 2021
calebcordry
approved these changes
Apr 21, 2021
calebcordry
reviewed
Apr 21, 2021
| rtcFetch = Services.scriptForDocOrNull(element) | ||
| .then((service) => { | ||
| userAssert(service, 'AMP-SCRIPT is not installed.'); | ||
| return service.fetch(url); |
There was a problem hiding this comment.
This is probably me not understanding how amp script works, but how to we ensure they are using the no-dom attr?
There was a problem hiding this comment.
From a security/ux standpoint, I don't think we actually need it to be nodom.
I.e. some pubs may want to have their amp-script perform both functions:
- As a normal amp-script
- As something that exports a fn for RTC
All the usual amp-script restrictions apply (no dom mutation without user activity, etc)
There was a problem hiding this comment.
Going to followup on this to see if sandboxed should imply nodom
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
* Ads RTC: support amp-script fetching. * flesh out example better. * revert unecessary diff * feedback from caleb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Fixes #33581.
amp-script.Blocked on ♻️ Extract AmpScriptService.fetch into its own fn. #33900