Add unit test

ampproject · Apr 19, 2021 · 8d84f48 · 8d84f48
1 parent 03ac23a
commit 8d84f48
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/src/service/real-time-config/real-time-config-impl.js b/src/service/real-time-config/real-time-config-impl.js
@@ -428,7 +428,10 @@ export class RealTimeConfigManager {
           errorReportingUrl
         );
       }
-      if (!Services.urlForDoc(this.ampDoc_).isSecure(url)) {
+      if (
+        !Services.urlForDoc(this.ampDoc_).isSecure(url) &&
+        !isAmpScriptUri(url)
+      ) {
         return this.buildErrorResponse_(
           RTC_ERROR_ENUM.INSECURE_URL,
           callout,
@@ -446,6 +449,7 @@ export class RealTimeConfigManager {
       if (url.length > MAX_URL_LENGTH) {
         url = this.truncUrl_(url);
       }
+
       return this.sendRtcCallout_(
         url,
         timeoutMillis,
@@ -516,7 +520,7 @@ export class RealTimeConfigManager {
     let rtcFetch;
     if (isAmpScriptUri(url)) {
       rtcFetch = Services.scriptForDocOrNull(element)
-        .then((service) => service.fetch(url, callout))
+        .then((service) => service.fetch(url))
         .then((json) => {
           checkStillCurrent();
           const rtcTime = Date.now() - this.rtcStartTime_;

diff --git a/test/unit/test-real-time-config.js b/test/unit/test-real-time-config.js
@@ -302,6 +302,30 @@ describes.realWin('real-time-config service', {amp: true}, (env) => {
         expectedRtcArray,
       });
     });
+
+    it('should fetch RTC from amp-script URIs', async () => {
+      const ampScriptFetch = env.sandbox.stub();
+      ampScriptFetch.returns(Promise.resolve({targeting: ['sports']}));
+      env.sandbox
+        .stub(Services, 'scriptForDocOrNull')
+        .returns(Promise.resolve({fetch: ampScriptFetch}));
+
+      const urls = ['amp-script:scriptId.functionName'];
+      setRtcConfig({urls, vendors: {}, timeoutMillis: 500});
+      const rtcResponse = await execute_(
+        element,
+        /* customMacros */ {},
+        /* consentState */ undefined,
+        /* consentString */ undefined,
+        /* consentMetadata */ undefined,
+        () => {}
+      );
+      expect(ampScriptFetch).calledWithExactly(
+        'amp-script:scriptId.functionName'
+      );
+      expect(rtcResponse[0].response).deep.equal({targeting: ['sports']});
+    });
+
     it('should send RTC callouts to inflated vendor URLs', () => {
       const vendors = {
         'fAkeVeNdOR': {SLOT_ID: 1, PAGE_ID: 2},