Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Allow <script> templates to be referenced by id. #26747

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

twifkak
Copy link
Member

@twifkak twifkak commented Feb 11, 2020

Fixes #26676.

@amp-owners-bot
Copy link

Hey @ampproject/wg-caching, these files were changed:

  • extensions/amp-mustache/validator-amp-mustache.protoascii
  • extensions/amp-script/validator-amp-script.protoascii
  • validator/validator-main.protoascii

@twifkak twifkak merged commit 47a4915 into ampproject:master Feb 11, 2020
@twifkak twifkak deleted the script_template branch February 11, 2020 23:14
honeybadgerdontcare added a commit that referenced this pull request Feb 12, 2020
* cl/294457507 Revision bump for #26475

* cl/294516530 Revision bump for #26708

* cl/294516739 Update node.js version numbers

* cl/294681603 Revision bump for #26747

Co-authored-by: honeybadgerdontcare <honeybadgerdontcare@users.noreply.github.com>
amaltas added a commit that referenced this pull request Feb 12, 2020
* cl/294457507 Revision bump for #26475

* cl/294516530 Revision bump for #26708

* cl/294516739 Update node.js version numbers

* cl/294681603 Revision bump for #26747

* Update package versions and README for nodejs and gulpjs. (Packages are
pushed  to npm repository)

Co-authored-by: honeybadgerdontcare <honeybadgerdontcare@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AMP Validator considers a reference to template script[type=text/plain] an error
5 participants