Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨amp-inline-gallery docs and validation rules #26708

Merged
merged 2 commits into from
Feb 10, 2020
Merged

✨amp-inline-gallery docs and validation rules #26708

merged 2 commits into from
Feb 10, 2020

Conversation

alanorozco
Copy link
Member

@alanorozco alanorozco commented Feb 10, 2020 •
edited
Loading

Unchanged clone of #26109, which had to be closed due to Github user email change/CLA issues.

  • Add docs for amp-inline-gallery elements and linking to amp-base-carousel for its usage.
  • Add validation rules for amp-inline-gallery elements.
  • Fix selector for finding the amp-base-carousel, when it is a direct child of the amp-inline-gallery.

@amp-owners-bot
Copy link

Hey @ampproject/wg-caching, these files were changed:

  • extensions/amp-inline-gallery/0.1/test/validator-amp-inline-gallery-pagination.html
  • extensions/amp-inline-gallery/0.1/test/validator-amp-inline-gallery-pagination.out
  • extensions/amp-inline-gallery/0.1/test/validator-amp-inline-gallery-thumbnails.html
  • extensions/amp-inline-gallery/0.1/test/validator-amp-inline-gallery-thumbnails.out
  • extensions/amp-inline-gallery/validator-amp-inline-gallery.protoascii

@alanorozco alanorozco mentioned this pull request Feb 10, 2020
Closed
@wassgha wassgha self-requested a review February 10, 2020 22:24
@alanorozco alanorozco merged commit e3be1b2 into ampproject:master Feb 10, 2020
@alanorozco alanorozco deleted the aig branch February 10, 2020 23:12
honeybadgerdontcare added a commit that referenced this pull request Feb 12, 2020
@amaltas @honeybadgerdontcare
Validator rollup (#26771)
d4800ac 
* cl/294457507 Revision bump for #26475

* cl/294516530 Revision bump for #26708

* cl/294516739 Update node.js version numbers

* cl/294681603 Revision bump for #26747

Co-authored-by: honeybadgerdontcare <honeybadgerdontcare@users.noreply.github.com>
amaltas added a commit that referenced this pull request Feb 12, 2020
@amaltas @honeybadgerdontcare
Update nodejs and gulpjs versions and README (#26774)
ac90be1 
* cl/294457507 Revision bump for #26475

* cl/294516530 Revision bump for #26708

* cl/294516739 Update node.js version numbers

* cl/294681603 Revision bump for #26747

* Update package versions and README for nodejs and gulpjs. (Packages are
pushed  to npm repository)

Co-authored-by: honeybadgerdontcare <honeybadgerdontcare@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wassgha wassgha wassgha approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alanorozco @wassgha @Gregable @googlebot @ampprojectbot