Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "♻️ Lint: include externs" #26445

Merged
merged 8 commits into from
Jan 22, 2020
Merged

Conversation

samouri
Copy link
Member

@samouri samouri commented Jan 22, 2020

Reverts #26228

Revert reasons (#26228 (comment)):

  1. Initial merge was done via 8 commits instead of a squashed 1
  2. There have been changes to the externs files that make them out of sync with the introduced lint rules (making master red)

@rsimha
Copy link
Contributor

rsimha commented Jan 22, 2020

Verified that this revert fixes broken master. Force merging to unblock development.

@rsimha rsimha merged commit 989eb0c into master Jan 22, 2020
samouri added a commit that referenced this pull request Jan 22, 2020
samouri added a commit that referenced this pull request Jan 23, 2020
* Revert "Revert "♻️ Lint: include externs" (#26445)"

This reverts commit 989eb0c.

* prettify preact extern
@rsimha rsimha deleted the revert-26228-prettify-externs branch February 13, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants