Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update I2I & I2S to reflect new Open Source process (#25530)" #26392

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

nainar
Copy link
Contributor

@nainar nainar commented Jan 17, 2020

This reverts commit d46416b.
Reverting because the original PR doesn't address the comment here: #25530 (comment)

@nainar nainar requested review from cramforce and removed request for sebastianbenz January 17, 2020 21:12
@nainar
Copy link
Contributor Author

nainar commented Jan 17, 2020

@cramforce for review. Thanks!

@nainar nainar merged commit 9b11063 into master Jan 17, 2020
nainar added a commit that referenced this pull request Jan 17, 2020
robinvanopstal added a commit to jungvonmatt/amphtml that referenced this pull request Jan 20, 2020
* master:
  [yahoonativeads-amp] code cleanup and bug fix (ampproject#26325)
  rephrased reasoning for text node  (ampproject#26393)
  Render video alt and title attributes in vertical rendering mdoe. (ampproject#26370)
  Revert "Update I2I & I2S to reflect new Open Source process (ampproject#25530)" (ampproject#26392)
  Skip amp story affiliate link test (ampproject#26386)
  Update I2I & I2S to reflect new Open Source process (ampproject#25530)
  ✨ Add support for `"intrisic"` layout for `<amp-script>` (ampproject#26369)
  📖 Rename Dev Channel to Experimental Channel in docs and comments (ampproject#26255)
  ✨Add support for AMP Story Quiz Reaction API calls (ampproject#26242)
  clarified text node behavior (ampproject#26376)

# Conflicts:
#	extensions/amp-script/amp-script.md
#	extensions/amp-timeago/amp-timeago.md
@rsimha rsimha deleted the revert-25530-opensource-idea-launch branch February 13, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants