Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Rename Dev Channel to Experimental Channel in docs and comments #26255

Merged
merged 18 commits into from
Jan 17, 2020
Merged

📖 Rename Dev Channel to Experimental Channel in docs and comments #26255

merged 18 commits into from
Jan 17, 2020

Conversation

rcebulko
Copy link
Contributor

@rcebulko rcebulko commented Jan 8, 2020

No description provided.

rsimha
rsimha reviewed Jan 9, 2020
View reviewed changes
@rcebulko
Copy link
Contributor Author

rcebulko commented Jan 9, 2020

I also reorganized the sections a bit. I felt the opt-in channels belong in the "Release Channels" section, and "Release Freezes" is now under "Release Cadence". WDYT?

mrjoro
mrjoro approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@mrjoro mrjoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; thanks!

danielrozenberg
danielrozenberg approved these changes Jan 9, 2020
View reviewed changes
@rcebulko rcebulko requested a review from rsimha January 10, 2020 22:06
rsimha
rsimha reviewed Jan 10, 2020
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested a couple of changes, including deleting an old file.

@rcebulko rcebulko requested a review from rsimha January 16, 2020 20:16
rsimha
rsimha approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after a couple more fixes.

@rcebulko rcebulko merged commit afebb3f into ampproject:master Jan 17, 2020
@rcebulko rcebulko deleted the channel branch January 17, 2020 17:48
robinvanopstal added a commit to jungvonmatt/amphtml that referenced this pull request Jan 20, 2020
@robinvanopstal
Merge branch 'master' into component-intro-tables
fd92c68 
* master:
  [yahoonativeads-amp] code cleanup and bug fix (ampproject#26325)
  rephrased reasoning for text node  (ampproject#26393)
  Render video alt and title attributes in vertical rendering mdoe. (ampproject#26370)
  Revert "Update I2I & I2S to reflect new Open Source process (ampproject#25530)" (ampproject#26392)
  Skip amp story affiliate link test (ampproject#26386)
  Update I2I & I2S to reflect new Open Source process (ampproject#25530)
  ✨ Add support for `"intrisic"` layout for `<amp-script>` (ampproject#26369)
  📖 Rename Dev Channel to Experimental Channel in docs and comments (ampproject#26255)
  ✨Add support for AMP Story Quiz Reaction API calls (ampproject#26242)
  clarified text node behavior (ampproject#26376)

# Conflicts:
#	extensions/amp-script/amp-script.md
#	extensions/amp-timeago/amp-timeago.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

@danielrozenberg danielrozenberg danielrozenberg approved these changes

@mrjoro mrjoro mrjoro approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rcebulko @danielrozenberg @mrjoro @rsimha @googlebot @ampprojectbot