Launch layoutbox-invalidate-on-scroll to 0.5% of prod #25730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Please create a feature tracking issue with a short test plan that describes (1) new expected behavior with 1-2 sample cases and (2) potential regression surface area. Work with @diantekyrie to verify this.
| @@ -34,7 +34,7 @@ | |||
| "swg-gpay-api": 1, | |||
| "hidden-mutation-observer": 1, | |||
| "ios-fixed-no-transfer": 1, | |||
| "layoutbox-invalidate-on-scroll": 1, | |||
| "layoutbox-invalidate-on-scroll": 0.05, | |||
There was a problem hiding this comment.
So that canary and rc will have the same fractional experiment. May not be required, since rc and control will have the same fraction.
jridgewell
force-pushed
the
invalidate-on-scroll
branch
from
404fb14
to
6b26628
Compare
dreamofabear
approved these changes
Nov 26, 2019
caroqliu
pushed a commit
to caroqliu/amphtml
that referenced
this pull request
Dec 5, 2019
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #25172