Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2S: layoutbox-invalidate-on-scroll experiment #25785

Closed
jridgewell opened this issue Nov 26, 2019 · 2 comments
Closed

I2S: layoutbox-invalidate-on-scroll experiment #25785

jridgewell opened this issue Nov 26, 2019 · 2 comments
Assignees
Labels
INTENT TO SHIP Proposes shipping an implemented significant new feature. https://bit.ly/amp-contribute-code WG: runtime

Comments

@jridgewell
Copy link
Contributor

Summary

This accomplishes the main goal of Layers (supporting nested scrolling elements) by invalidating the layout boxes of elements inside a nested scrolling element after a scroll.

Eg, if an <amp-carousel> (once it migrates off of Ownership system) were to scroll, all <amp-img>s inside it would invalidate their layout boxes. Once the next Resources pass happens, the images would be remeasured, and we'll now detect that the image has moved closer/further from viewport.

The layout boxes themselves are still page-absolute and not viewport-relative. This means we keep the speed benefits that stopped us from shipping Layers.

Intent-to-implement (I2I) issue

#25172

Experiment(s) to enable

  • layoutbox-invalidate-on-scroll

Required release version

1911042323000, #25319

Demo instructions

Load https://gaitz.github.io/AMP-issues/amp-img-load.html, scroll the carousels

Additional context

/cc @ampproject/wg-approvers

@jridgewell jridgewell added the INTENT TO SHIP Proposes shipping an implemented significant new feature. https://bit.ly/amp-contribute-code label Nov 26, 2019
@jridgewell jridgewell self-assigned this Nov 26, 2019
@cramforce
Copy link
Member

cramforce commented Dec 4, 2019

LGTM

@dreamofabear
Copy link

Launched in #26430.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTENT TO SHIP Proposes shipping an implemented significant new feature. https://bit.ly/amp-contribute-code WG: runtime
Projects
None yet
Development

No branches or pull requests

3 participants