Add extension buffer to registerElement examples #21030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…registering an element with AMP.
gmajoulet
approved these changes
Feb 22, 2019
|
cc @rsimha FYI |
cvializ
approved these changes
Feb 22, 2019
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Add AMP.extension buffer to registerElement line. * Modify building-an-amp-extension.md to include extension buffer when registering an element with AMP.
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
* Add AMP.extension buffer to registerElement line. * Modify building-an-amp-extension.md to include extension buffer when registering an element with AMP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11346
Examples in building-an-amp-extension.md and the
gulp make-extensionscript using AMP.registerElement are error-causing. These changes reflect how existing AMP components place the registerElement call in their implementation, universally updated in #11013, #11018, and #11039.