Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to describes tests and AMP.extension buffer, set 3 #11039

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Switch to describes tests and AMP.extension buffer, set 3 #11039

merged 1 commit into from
Aug 22, 2017

Conversation

dvoytenko
Copy link
Contributor

Partial for #10705.

Follow up to #11018 and #11013.

aghassemi
aghassemi approved these changes Aug 22, 2017
View reviewed changes
Copy link
Contributor

@aghassemi aghassemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR: timeout as describes config so we don't have to switch between function and () => :)

@dvoytenko
Copy link
Contributor Author

@aghassemi Noted.

@dvoytenko dvoytenko merged commit 2af358f into ampproject:master Aug 22, 2017
@dvoytenko dvoytenko deleted the ampdoc2-ext-tests branch August 22, 2017 22:42
@cvializ
Copy link
Contributor

cvializ commented Aug 23, 2017

+💯 for timeout in describes

@muxin muxin mentioned this pull request Aug 29, 2017
Closed
@caroqliu caroqliu mentioned this pull request Feb 22, 2019
Merged
@Elisabeth1983 Elisabeth1983 mentioned this pull request Dec 19, 2023
Open
@t10-13rocket t10-13rocket mentioned this pull request Dec 19, 2023
Open
@muratkalenderoglu muratkalenderoglu mentioned this pull request Dec 19, 2023
Open
@Masterci84 Masterci84 mentioned this pull request Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aghassemi aghassemi aghassemi approved these changes

@cramforce cramforce Awaiting requested review from cramforce

@lannka lannka Awaiting requested review from lannka

@camelburrito camelburrito Awaiting requested review from camelburrito

@cvializ cvializ Awaiting requested review from cvializ

@erwinmombay erwinmombay Awaiting requested review from erwinmombay

@jridgewell jridgewell Awaiting requested review from jridgewell

@muxin muxin Awaiting requested review from muxin

@zhouyx zhouyx Awaiting requested review from zhouyx

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dvoytenko @cvializ @aghassemi @googlebot