Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Guard against getBoundingClientRect to prevent unspecified errors in IE. #20731

Merged
merged 13 commits into from
Feb 14, 2019
Merged

🐛 Guard against getBoundingClientRect to prevent unspecified errors in IE. #20731

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ff8d112
Guard against `Element.getBoundingClientRect`.
delima02 Feb 7, 2019
c1c4981
Refactor solution.
delima02 Feb 7, 2019
520453b
Check if element exists in the DOM.
delima02 Feb 11, 2019
4ac262e
Fix solution using `Node.isConnected`.
delima02 Feb 11, 2019
67a961e
Correct the default value of the desired DOMRect
delima02 Feb 11, 2019
eac4f0a
Patch getBoundingClientRect for unsupported browsers. Alternative sol…
delima02 Feb 11, 2019
1f835d8
Refactor patch.
delima02 Feb 12, 2019
15526f0
Fix - use assigned variable rect, previously unused.
delima02 Feb 13, 2019
fdb9133
Fix imports.
delima02 Feb 13, 2019
dfaadbf
Merge branch 'delima02-unspecified-error' of github.com:delima02/amph…
delima02 Feb 13, 2019
39a6496
Minor fixes.
delima02 Feb 13, 2019
9d5d887
Make the return type of getBoundingClientRect be consistent with usages
delima02 Feb 13, 2019
b191fce
File overview comment and a minor fix.
delima02 Feb 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/service/viewport/viewport-binding-natural.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,12 @@ export class ViewportBindingNatural_ {

/** @override */
getLayoutRect(el, opt_scrollLeft, opt_scrollTop) {
const b = el./*OK*/getBoundingClientRect();
// Default value for when 'el' is has not been added to the page yet.
let b = 0;
jridgewell marked this conversation as resolved.
Show resolved Hide resolved
if (el != undefined && el != null) {
jridgewell marked this conversation as resolved.
Show resolved Hide resolved
b = el./*OK*/getBoundingClientRect();
}

if (this.useLayers_) {
return layoutRectLtwh(b.left, b.top, b.width, b.height);
}
Expand Down