Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Guard against getBoundingClientRect to prevent unspecified errors in IE. #20731

Merged
merged 13 commits into from
Feb 14, 2019
Merged

🐛 Guard against getBoundingClientRect to prevent unspecified errors in IE. #20731

merged 13 commits into from
Feb 14, 2019

Commits on Feb 7, 2019

  1. Guard against Element.getBoundingClientRect.

    @delima02
    delima02 committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    ff8d112 View commit details
    Browse the repository at this point in the history

  2. Refactor solution.

    @delima02
    delima02 committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    c1c4981 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2019

  1. Check if element exists in the DOM.

    @delima02
    delima02 committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    520453b View commit details
    Browse the repository at this point in the history

  2. Fix solution using Node.isConnected.

    @delima02
    delima02 committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    4ac262e View commit details
    Browse the repository at this point in the history

  3. Correct the default value of the desired DOMRect

    @delima02
    delima02 committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    67a961e View commit details
    Browse the repository at this point in the history

  4. Patch getBoundingClientRect for unsupported browsers. Alternative sol… 

    …ution
    @delima02
    delima02 committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    eac4f0a View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. Refactor patch.

    @delima02
    delima02 committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    1f835d8 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. Fix - use assigned variable rect, previously unused.

    @delima02
    delima02 committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    15526f0 View commit details
    Browse the repository at this point in the history

  2. Fix imports.

    @delima02
    delima02 committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    fdb9133 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'delima02-unspecified-error' of github.com:delima02/amph… 

    …tml into delima02-unspecified-error
    @delima02
    delima02 committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    dfaadbf View commit details
    Browse the repository at this point in the history

  4. Minor fixes.

    @delima02
    delima02 committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    39a6496 View commit details
    Browse the repository at this point in the history

  5. Make the return type of getBoundingClientRect be consistent with usages

    @delima02
    delima02 committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    9d5d887 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2019

  1. File overview comment and a minor fix.

    @delima02
    delima02 committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    b191fce View commit details
    Browse the repository at this point in the history