Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Points the docs for creating an AMP extension to the new contribution docs #20365

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Points the docs for creating an AMP extension to the new contribution docs #20365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
point to new contribution docs
  • Loading branch information
@mrjoro
mrjoro authored Jan 16, 2019
commit ae68b766f5f6570225fdfbe291d884e8612e2ca0
14 changes: 4 additions & 10 deletions contributing/building-an-amp-extension.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ extensions. If you'd like to add an extension to support your company
video player, rich embed or just a general UI component like a star
rating viewer, you'd do this by building an extension.

- [A word on contributing](#a-word-on-contributing)
- [Getting started](#getting-started)
- [Naming](#naming)
- [Directory structure](#directory-structure)
- [Extend AMP.BaseElement](#extend-ampbaseelement)
Expand All @@ -27,17 +27,11 @@ rating viewer, you'd do this by building an extension.
- [Type checking](#type-checking)
- [Example PRs](#example-prs)

# Checklist for creating an experiment
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @alabiaga I wasn't sure what this section was for so I've removed it.

## Getting started

-[] Create your directory structure.
-[] Create an experiment.
-[] Check previous PRs of past experiments to model your extension after, if applicable.
This document describes how to create a new AMP extension, which is one of the most common ways of adding a new feature to AMP.

## A word on contributing

We suggest that you open an "Intent to Implement" GitHub issue for your
extension as early as you can, so that we can advise you on next steps or provide early feedback on the implementation or naming. For details, see [CONTRIBUTING.md
for more details](../CONTRIBUTING.md#phase-concept-design).
Before diving into the details on creating a new AMP extension, please familiarize yourself with the [general process for contributing code and features to AMP](https://github.com/ampproject/amphtml/blob/master/contributing/contributing-code.md). Since you are adding a new extension you will likely need to follow the [process for making a significant change](https://github.com/ampproject/amphtml/blob/master/contributing/contributing-code.md#process-for-significant-changes), including filing an ["Intent to Implement" issue](https://github.com/ampproject/amphtml/labels/INTENT%20TO%20IMPLEMENT) and finding a reviewer before you start significant development.

## Naming

Expand Down