Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Points the docs for creating an AMP extension to the new contribution docs #20365

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

mrjoro
Copy link
Member

@mrjoro mrjoro commented Jan 16, 2019

This updates the docs for creating a new AMP extension to point to the updated contribution docs, making it more clear that there is a process a contributor will need to go through to get the new extension approved.

@mrjoro mrjoro requested a review from alabiaga January 16, 2019 01:24
@@ -27,17 +27,11 @@ rating viewer, you'd do this by building an extension.
- [Type checking](#type-checking)
- [Example PRs](#example-prs)

# Checklist for creating an experiment
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @alabiaga I wasn't sure what this section was for so I've removed it.

@alabiaga
Copy link
Contributor

@mrjoro Joey pls take a look at #20372. Perhaps you'd like to include those changes in this PR or just comment on that PR and I can make the changes. Thanks!

@mrjoro
Copy link
Member Author

mrjoro commented Jan 16, 2019

@alabiaga thanks for the review.

Your PR covers a different file so we can handle that one update.

@mrjoro mrjoro merged commit 5d61ba8 into master Jan 16, 2019
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
@rsimha rsimha deleted the mrjoro-ampextdocs branch May 23, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants