Fix amp-analytics related bugs. #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'requests': { | ||
| 'host': 'https://www.google-analytics.com', | ||
| 'basePrefix': 'v=1&_v=a0&aip=true&_s=${hitCount}&dl=${canonicalUrl}&' + | ||
| 'basePrefix': 'v=1&_v=a0&aip=true&_s=${hitCount}&' + |
There was a problem hiding this comment.
Just out of curiosity: Would you not want to send the referrer somewhere here?
There was a problem hiding this comment.
Thanks for catching that. Added document referrer and also added a comment about vars that would be nice to have...
|
Tuned PR title and description a bit. |
|
ptal. |
Have a more customizable documentLocation for GA. This way, if a person wants to send both canonicalUrl and ampdocUrl in a hit, they can.
| } | ||
| // TODO(btownsend, #871): Add a generic hit format to make custom analytics | ||
| // easier. | ||
| }, | ||
|
|
||
| 'googleanalytics': { | ||
| 'vars': { | ||
| 'eventValue': "0", | ||
| 'documentLocation': 'AMPDOC_URL' |
There was a problem hiding this comment.
curious: why not dl=${ampdocUrl} below?
There was a problem hiding this comment.
If I do that, people will have to override the ampdocUrl property to set a different value for dl. That looks and feel counter-intuitive. SInce this is a common thing many people do, I opted for this solution instead.
|
LGTM |
cramforce
added a commit
that referenced
this pull request
Jan 25, 2016
Fix amp-analytics related bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1494
Fixes #1491
cc: @btownsend