Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GA Vendor config - change field name for socialActionTarget #1494

Closed
pfrisella opened this issue Jan 21, 2016 · 1 comment
Closed

GA Vendor config - change field name for socialActionTarget #1494

pfrisella opened this issue Jan 21, 2016 · 1 comment

Comments

@pfrisella
Copy link

I'd like to propose changing social interaction field from socialActionTarget to socialTarget.
This will make social interaction field names consistent with analytics.js field names.
@rudygalfi
Copy link
Contributor

cc @avimehta

@avimehta avimehta mentioned this issue Jan 24, 2016
Merged
avimehta added a commit to avimehta/amphtml that referenced this issue Jan 24, 2016
@avimehta
Fix for ampproject#1494 and ampproject#1491
cab2be9 
Have a more customizable documentLocation for GA. This way, if a person wants to send both canonicalUrl and ampdocUrl in a hit, they can.
@stellachui stellachui mentioned this issue Feb 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pfrisella @rudygalfi