Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the new boilerplate (spec file change + also_requires feature). #1345

Merged
merged 1 commit into from
Jan 7, 2016
Merged

Allow the new boilerplate (spec file change + also_requires feature). #1345

merged 1 commit into from
Jan 7, 2016

Commits on Jan 7, 2016

  1. Allow the new boilerplate (spec file chng + also_requires feature). 

    - no deprecation warnings for now
- old and new boilerplate cannot be mixed (to ensure this, I'm adding the also_requires
  facility).
- mandatory whitespace in the boilerplate is matched against \s+, so
  it's OK to put newlines tabs etc. into there

The Google doc describing the new boilerplate (https://docs.google.com/document/d/1gZFaKvcDffceJNaI3bYfuYPtYU5u2y6UhE5wBPTsJ9w/edit#) also specifies a more permissive matching but this requires parsing the CSS. We'll want to do this eventually, but not in this change, hence just something with a not super complicated regex that's good enough so we can live with it for now.
    @powdercloud
    powdercloud committed Jan 7, 2016
    Configuration menu
    Copy the full SHA
    d177195 View commit details
    Browse the repository at this point in the history