Allow the new boilerplate (spec file change + also_requires feature). #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no deprecation warnings for now - old and new boilerplate cannot be mixed (to ensure this, I'm adding the also_requires facility). - mandatory whitespace in the boilerplate is matched against \s+, so it's OK to put newlines tabs etc. into there The Google doc describing the new boilerplate (https://docs.google.com/document/d/1gZFaKvcDffceJNaI3bYfuYPtYU5u2y6UhE5wBPTsJ9w/edit#) also specifies a more permissive matching but this requires parsing the CSS. We'll want to do this eventually, but not in this change, hence just something with a not super complicated regex that's good enough so we can live with it for now.
Gregable
changed the title
powdercloud
added a commit
that referenced
this pull request
Jan 7, 2016
Allow the new boilerplate (spec file change + also_requires feature).
|
does this mean that i can change all example files to use the new boilerplate? |
|
Probably not. The tests are still running against the released minified version of the validator, yes? That doesn't have this change yet. We'll probably hold off allowing it until the cdn.ampproject.org backends pick up the change as well, so that publishers don't roll something out which validates in their browser but doesn't validate on the cdn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
facility).
it's OK to put newlines tabs etc. into there
The Google doc describing the new boilerplate (https://docs.google.com/document/d/1gZFaKvcDffceJNaI3bYfuYPtYU5u2y6UhE5wBPTsJ9w/edit#) also specifies a more permissive matching but this requires parsing the CSS. We'll want to do this eventually, but not in this change, hence just something with a not super complicated regex that's good enough so we can live with it for now.