Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools(presubmit): add globbing for whitelist #1240

Merged
merged 1 commit into from
Dec 23, 2015
Merged

tools(presubmit): add globbing for whitelist #1240

merged 1 commit into from
Dec 23, 2015

Conversation

erwinmombay
Copy link
Member

No description provided.

@erwinmombay erwinmombay mentioned this pull request Dec 23, 2015
Merged
@erwinmombay
Copy link
Member Author

/cc @cramforce

@dvoytenko
Copy link
Contributor

Thanks @erwinmombay ! Globs are indeed a bit dangerous. Instead I was wondering if we could just automatically whitelist test/ files for all restrictions. That way we can hold off on globs in the config and not worry about every test file.

@erwinmombay
Copy link
Member Author

@dvoytenko gotcha, will fix

@erwinmombay
Copy link
Member Author

@dvoytenko updated, please review. thanks

@cramforce
Copy link
Member

LGTM

erwinmombay added a commit that referenced this pull request Dec 23, 2015
@erwinmombay
Merge pull request #1240 from erwinmombay/minimatch
21be3b4 
tools(presubmit): add globbing for whitelist
@erwinmombay erwinmombay merged commit 21be3b4 into ampproject:master Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dvoytenko dvoytenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erwinmombay @dvoytenko @cramforce