Turn viewer and viewport service into core services. #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credit goes to @aaron on whose PR this is based. I realized, though, that viewer and viewport would be pretty hard and frustrating, so I chose to finish it myself. Part of ampproject#1055
cramforce
force-pushed
the
viewer-service
branch
from
674fe6e
to
845a65b
Compare
cramforce
added a commit
that referenced
this pull request
Dec 23, 2015
Turn viewer and viewport service into core services.
| 'src/service/history-impl.js', | ||
| 'src/service/viewer-impl.js', | ||
| 'src/service/viewport-impl.js', | ||
| 'test/functional/test-cid.js', |
There was a problem hiding this comment.
/cc @erwinmombay is there a way for us to declare whitelists for the whole test/ directory? I don't quite see a reason to be protective over this kind of uses in tests.
There was a problem hiding this comment.
not currently, i didnt since i thought that people might unintentionally whitelist something they shouldnt have. but now that the list is growing, might as well.
added PR/feature here #1240
/cc @cramforce
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit goes to @aaron on whose PR this is based. I realized, though, that viewer and viewport would be pretty hard and frustrating, so I chose to finish it myself.
Good impact on code size for extensions that pull these in.
Part of #1055
Obsoletes #1122 (I'm so sorry, but looking at this change it was probably better this way).