Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify scroll tracking and greatly increase frequency of viewability events #1163

Merged
merged 1 commit into from
Dec 18, 2015
Merged

Simplify scroll tracking and greatly increase frequency of viewability events #1163

merged 1 commit into from
Dec 18, 2015

Commits on Dec 18, 2015

  1. Simplify scroll tracking and greatly increase frequency in which we 

    emit viewport change events on scroll.

- The scroll event now always fires in vsync and always measures
scrollTop.
- The viewport change event now happens at the latest 3 frames after
scrolling ended.
- Increased speed at which we send change event. Needed due to resolution at slow speed, but I also feel the value is better.

Changes ad intersection to fire "on scroll". Fixes ampproject#873

Fixes a bug where only the first viewability provider in an ad would get an initial viewability change record. Fixes ampproject#1126
    @cramforce
    cramforce committed Dec 18, 2015
    Configuration menu
    Copy the full SHA
    3543226 View commit details
    Browse the repository at this point in the history